Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] MultiSelect: inject index to ValueCopmonent #3928

Merged
merged 2 commits into from Apr 18, 2023
Merged

[@mantine/core] MultiSelect: inject index to ValueCopmonent #3928

merged 2 commits into from Apr 18, 2023

Conversation

vaynevayne
Copy link
Contributor

inject index to ValueComponent

map index to ValueComponent
@vaynevayne
Copy link
Contributor Author

to support maxTagCount, like https://ant.design/components/select-cn#components-select-demo-responsive
we need inject index to ValueComponent,

You might want to use value.length simulation, but it's not.
User cannot implement it. because value.length control only one ValueCopmponent ,
we need render different value,so we need index
https://codesandbox.io/s/loving-chihiro-tmchzu?file=/src/Demo.tsx

@vaynevayne vaynevayne changed the title Update MultiSelect.tsx [@mantine/core]: [MultiSelect] inject index to ValueCopmonent Mar 28, 2023
@vaynevayne vaynevayne changed the title [@mantine/core]: [MultiSelect] inject index to ValueCopmonent [@mantine/core] MultiSelect: inject index to ValueCopmonent Mar 28, 2023
@rtivital rtivital merged commit f8c35f7 into mantinedev:master Apr 18, 2023
1 check passed
@rtivital
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants