Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@mantine/core] make MantineThemeColorsOverride an interface instead of type #4816

Merged
merged 2 commits into from Sep 20, 2023
Merged

[@mantine/core] make MantineThemeColorsOverride an interface instead of type #4816

merged 2 commits into from Sep 20, 2023

Conversation

matheusvellone
Copy link
Contributor

This is needed to allow MantineThemeColorsOverride to be overwritten

@matheusvellone
Copy link
Contributor Author

matheusvellone commented Sep 20, 2023 •
edited

Should I readd v6 docs section to v7 docs too?
https://v6.mantine.dev/theming/colors/#add-custom-colors-types

Done

@rtivital
Copy link
Member

@matheusvellone please fix failing tests

@matheusvellone
Copy link
Contributor Author

Done @rtivital

@rtivital rtivital merged commit 41d11ee into mantinedev:master Sep 20, 2023
1 check passed
@rtivital
Copy link
Member

Thanks!

@matheusvellone matheusvellone deleted the patch-1 branch September 20, 2023 20:09
@Ryiski Ryiski mentioned this pull request Sep 21, 2023
Merged
@renovate renovate bot mentioned this pull request Dec 8, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matheusvellone @rtivital