Add "size" popover middleware to fix overflow issues in Popover.Dropdown #5213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranquild
commented
Nov 7, 2023
| placement: options.position, | ||
| middleware: [ | ||
| ...getPopoverMiddlewares(options), | ||
| ...(options.width === 'target' |
There was a problem hiding this comment.
Moved to getPopoverMiddlewares
ranquild
commented
Nov 7, 2023
| @@ -74,22 +102,9 @@ export function usePopover(options: UsePopoverOptions) { | |||
| } | |||
| }; | |||
|
|
|||
| const floating = useFloating({ | |||
| const floating: UseFloatingReturn<Element> = useFloating({ | |||
There was a problem hiding this comment.
Without an explicit type TS throws an error
|
Thanks! |
ranquild
added a commit
to ranquild/mantine
that referenced
this pull request
Nov 7, 2023
This was referenced Nov 7, 2023
Merged
rtivital
pushed a commit
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the
Popover.Dropdowncontent is tall, there is no way to add scrollbars (overflow) properly as the dropdown overflows the page. Reproduction https://codesandbox.io/s/amazing-nobel-s6zqy8This issue is supposed to be fixed by size middleware in
floating-ui. This PR fixes the issue by addingsizeoption inPopoverMiddlewareswhich enables thesizemiddleware, which in turn usesavailableWidthandavailableHeightperfloating-uidocs.I decided not to set
overflow: autoautomatically inPopover.Dropdownbecause in some places there might be a requirement to shrink the content and not to add scrollbars.How to verify:
yarn storybookIssue (codesandbox):
Fix (storybook):
