Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@mantine/core] NumberInput: Fix (#5432) #5471

Merged
merged 3 commits into from Jan 3, 2024
Merged

[@mantine/core] NumberInput: Fix (#5432) #5471

merged 3 commits into from Jan 3, 2024

Conversation

giveerr
Copy link
Contributor

@giveerr giveerr commented Dec 24, 2023 •
edited by rtivital

I think we should use value instead of floatValue when floatValue is largerThan MAX_SAFE_INTEGER or else its just adding zeros to the end

react-number-format example

Fixes #5432

@qweered
Copy link
Contributor

qweered commented Dec 24, 2023

Can you add unit test for this?

@giveerr
Copy link
Contributor Author

giveerr commented Dec 24, 2023 •
edited

Ok got it 👍🏻

@rtivital rtivital merged commit be8f5c5 into mantinedev:master Jan 3, 2024
1 check passed
@rtivital
Copy link
Member

rtivital commented Jan 3, 2024

Thanks!

@renovate renovate bot mentioned this pull request Feb 26, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NumberInput is not working as intended with large numbers
3 participants
@giveerr @qweered @rtivital