[@mantine/core]: PinInput - some improvements #5704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kkaplita
commented
Feb 2, 2024
•
kkaplita
commented
- typing and pasting code problems
- now you can enter a value not only from the first input (previously, entering a value in, for example, the third input would change the value in the first input, but the focus would shift to the next one, i.e., the fourth input)
- when deleting a character in inputs, the values of subsequent inputs remain unchanged (previously, deleting a character in the middle of a PIN, for instance, would shift values from right to left in the inputs)
- paste a value from the clipboard that has any whitespace or line breaks - fixed
- added a few more tests
- typing and pasting code problems - now you can enter a value not only from the first input (previously, entering a value in, for example, the third input would change the value in the first input, but the focus would shift to the next one, i.e., the fourth input) - when deleting a character in inputs, the values of subsequent inputs remain unchanged (previously, deleting a character in the middle of a PIN, for instance, would shift values from right to left in the inputs) - added a few more tests
kkaplita
changed the title
|
I've had some issues with this component before, I was considering ditching it and writing my own from scratch because of it. Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.