Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes npm script errors on Windows #5711

Merged
merged 5 commits into from Feb 26, 2024
Merged

Conversation

ktunador
Copy link
Contributor

@ktunador ktunador commented Feb 2, 2024

Fixes issues for the following npm scripts on Windows:

  • npm test (npm run lint)
  • npm run build all
  • npm run docs:build
  • npm run clean

Changes are tested on:

  • Windows 10
  • Fedora 39
  • Ubuntu 22.04

```
> mantine-a91763c0e2@7.5.1 stylelint
> stylelint '**/*.css' --cache

Error: No files matching the pattern "'**/*.css'" were found.
```
Reference: stylelint/stylelint#4178 (comment)
`rimraf` doesn't treat arguments as glob patterns by default, and Windows doesn't allow `*` character in paths.

From the docs
```
  -G --no-glob         Treat arguments as literal paths, not globs (default)
  -g --glob            Treat arguments as glob patterns
```
@rtivital rtivital merged commit c8bf528 into mantinedev:master Feb 26, 2024
@rtivital
Copy link
Member

Thanks!

@ktunador ktunador deleted the fix-win-build branch March 3, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants