[@mantine/dates] Fix error with timezones in Month #5916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1g0rrr
changed the title
|
Thanks! |
thomson2k
reviewed
Mar 26, 2024
| @@ -175,7 +175,6 @@ export const Month = factory<MonthFactory>((_props, ref) => { | |||
| const dates = getMonthDays({ | |||
| month, | |||
| firstDayOfWeek: ctx.getFirstDayOfWeek(firstDayOfWeek), | |||
| timezone: ctx.timezone || undefined, | |||
There was a problem hiding this comment.
It breaks test. You made it more understandable and safe by taking out the "timezone" property from both the function call and the object setup. This change guarantees that you're not trying to set a property that isn't recognized in the type definition of getMonthDays or the object itself.
There was a problem hiding this comment.
What test does it break? The CI passed.
There was a problem hiding this comment.
It no longer break tests. It was fixed after my comment
There was a problem hiding this comment.
I did not get it. Is the PR fine or is there some issue that you've found?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5840
The problem was that variables startOfMonth and endOfMonth shifted by timezone once and then shifted again during clicks.
At version 7.4.2 which works ok, timezone at getMonthDays was always "undefined" there for it worked good as mentioned in the Issue. With new version of Month.tsx in 7.5.0 timezone is not undefined and so there is a double shift of date.
Is this a rigth direction to solve it?