[@mantine/spotlight] Search for the action item in the document or in ShadowDOMs #6400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2jordan3
reviewed
Jun 17, 2024
|
Please fix errors in tests |
|
It breaks the spotlight when escape key is pressed with the following error: spotlight.store.ts:60 Uncaught (in promise) DOMException: Failed to execute 'querySelector' on 'Document': '#' is not a valid selector.
at findElementByQuerySelector (http://localhost:2356/packages_mantine_spotlight_src_Spotlight_tsx-node_modules_tabler_icons-react_dist_esm_icons_I-f23c65.iframe.bundle.js:1802:26)
at selectAction (http://localhost:2356/packages_mantine_spotlight_src_Spotlight_tsx-node_modules_tabler_icons-react_dist_esm_icons_I-f23c65.iframe.bundle.js:1823:25)
at http://localhost:2356/packages_mantine_spotlight_src_Spotlight_tsx-node_modules_tabler_icons-react_dist_esm_icons_I-f23c65.iframe.bundle.js:1860:9 |
|
You can view the demo in the storybook – http://localhost:2356/?path=/story/spotlight--demo-usage |
Since |
|
Thanks! |
davydkov
added a commit
to likec4/likec4
that referenced
this pull request
Jul 11, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@mantine/core](https://mantine.dev/) ([source](https://togithub.com/mantinedev/mantine/tree/HEAD/packages/@mantine/core)) | [`7.11.0` -> `7.11.1`](https://renovatebot.com/diffs/npm/@mantine%2fcore/7.11.0/7.11.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@mantine/core](https://mantine.dev/) ([source](https://togithub.com/mantinedev/mantine/tree/HEAD/packages/@mantine/core)) | [`^7.11.0` -> `^7.11.1`](https://renovatebot.com/diffs/npm/@mantine%2fcore/7.11.0/7.11.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@mantine/hooks](https://mantine.dev) ([source](https://togithub.com/mantinedev/mantine/tree/HEAD/packages/@mantine/hooks)) | [`7.11.0` -> `7.11.1`](https://renovatebot.com/diffs/npm/@mantine%2fhooks/7.11.0/7.11.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@mantine/hooks](https://mantine.dev) ([source](https://togithub.com/mantinedev/mantine/tree/HEAD/packages/@mantine/hooks)) | [`^7.11.0` -> `^7.11.1`](https://renovatebot.com/diffs/npm/@mantine%2fhooks/7.11.0/7.11.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [@mantine/vanilla-extract](https://mantine.dev) ([source](https://togithub.com/mantinedev/mantine/tree/HEAD/packages/@mantine/vanilla-extract)) | [`7.11.0` -> `7.11.1`](https://renovatebot.com/diffs/npm/@mantine%2fvanilla-extract/7.11.0/7.11.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mantinedev/mantine (@​mantine/core)</summary> ### [`v7.11.1`](https://togithub.com/mantinedev/mantine/releases/tag/7.11.1) [Compare Source](https://togithub.com/mantinedev/mantine/compare/7.11.0...7.11.1) ##### What's Changed - `[@mantine/core]` Add option to display `nothingFoundMessage` when data is empty in Select and MultiSelect components ([#​6477](https://togithub.com/mantinedev/mantine/issues/6477)) - `[@mantine/core]` Tooltip: Add `defaultOpened` prop support ([#​6466](https://togithub.com/mantinedev/mantine/issues/6466)) - `[@mantine/core]` PinInput: Fix incorrect rtl logic ([#​6382](https://togithub.com/mantinedev/mantine/issues/6382)) - `[@mantine/core]` Popover: Fix `floatingStrategy="fixed"` not having `position:fixed` styles ([#​6419](https://togithub.com/mantinedev/mantine/issues/6419)) - `[@mantine/spotlight]` Fix spotlight not working correctly with shadow DOM ([#​6400](https://togithub.com/mantinedev/mantine/issues/6400)) - `[@mantine/form]` Fix `onValuesChange` using stale values ([#​6392](https://togithub.com/mantinedev/mantine/issues/6392)) - `[@mantine/carousel]` Fix `onSlideChange` using stale props values ([#​6393](https://togithub.com/mantinedev/mantine/issues/6393)) - `[@mantine/charts]` Fix unexpected padding on the right side of the chart in BarChart, AreaChart and LineChart components ([#​6467](https://togithub.com/mantinedev/mantine/issues/6467)) - `[@mantine/core]` Select: Fix `onChange` being called with the already selected if it has been picked from the dropdown ([#​6468](https://togithub.com/mantinedev/mantine/issues/6468)) - `[@mantine/dates]` DatePickerInput: Fix `highlightToday` not working ([#​6471](https://togithub.com/mantinedev/mantine/issues/6471)) - `[@mantine/core]` NumberInput: Fix incorrect handling of numbers larger than max safe integer on blur ([#​6407](https://togithub.com/mantinedev/mantine/issues/6407)) - `[@mantine/core]` Tooltip: Fix tooltip arrow being incompatible with headless mode ([#​6458](https://togithub.com/mantinedev/mantine/issues/6458)) - `[@mantine/core]` ActionIcon: Fix loading styles inconsistency with Button component ([#​6460](https://togithub.com/mantinedev/mantine/issues/6460)) - `[@mantine/charts]` PieChart: Fix key error for duplicated `name` data ([#​6067](https://togithub.com/mantinedev/mantine/issues/6067)) - `[@mantine/core]` Modal: Fix `removeScrollProps.ref` not being compatible with React 19 ([#​6446](https://togithub.com/mantinedev/mantine/issues/6446)) - `[@mantine/core]` TagsInput: Fix `selectFirstOptionOnChange` prop not working ([#​6337](https://togithub.com/mantinedev/mantine/issues/6337)) - `[@mantine/hooks]` use-eye-dropper: Fix Opera being incorrectly detected as a supported browser ([#​6307](https://togithub.com/mantinedev/mantine/issues/6307)) - `[@mantine/core]` Fix `:host` selector now working correctly in `cssVariablesSelector` of MantineProvider ([#​6404](https://togithub.com/mantinedev/mantine/issues/6404)) - `[@mantine/core]` TagsInput: Fix `onChange` being called twice when Enter key is pressed in some cases ([#​6416](https://togithub.com/mantinedev/mantine/issues/6416)) - `[@mantine/modals]` Fix Modal overrides type augmentation not working with TypeScript 5.5 ([#​6443](https://togithub.com/mantinedev/mantine/issues/6443)) - `[@mantine/core]` Tree: Fix `levelOffset` prop being added to the root DOM element ([#​6461](https://togithub.com/mantinedev/mantine/issues/6461)) ##### New Contributors - [@​bsl-zcs](https://togithub.com/bsl-zcs) made their first contribution in [mantinedev/mantine#6461 - [@​florisdg](https://togithub.com/florisdg) made their first contribution in [mantinedev/mantine#6443 - [@​snlacks](https://togithub.com/snlacks) made their first contribution in [mantinedev/mantine#6425 - [@​lid0a](https://togithub.com/lid0a) made their first contribution in [mantinedev/mantine#6415 - [@​Knamer95](https://togithub.com/Knamer95) made their first contribution in [mantinedev/mantine#6416 - [@​yyytae0](https://togithub.com/yyytae0) made their first contribution in [mantinedev/mantine#6404 - [@​toanxyz](https://togithub.com/toanxyz) made their first contribution in [mantinedev/mantine#6388 - [@​viktorkasap](https://togithub.com/viktorkasap) made their first contribution in [mantinedev/mantine#6307 - [@​alexlapp](https://togithub.com/alexlapp) made their first contribution in [mantinedev/mantine#6337 - [@​brycefranzen](https://togithub.com/brycefranzen) made their first contribution in [mantinedev/mantine#6446 - [@​marcobiedermann](https://togithub.com/marcobiedermann) made their first contribution in [mantinedev/mantine#6442 - [@​mullwar](https://togithub.com/mullwar) made their first contribution in [mantinedev/mantine#6067 - [@​gruschis](https://togithub.com/gruschis) made their first contribution in [mantinedev/mantine#6400 - [@​jpranays](https://togithub.com/jpranays) made their first contribution in [mantinedev/mantine#6466 **Full Changelog**: mantinedev/mantine@7.11.0...7.11.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/likec4/likec4). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on my proposed fix on Discord, here's finally the PR.
The added method tries to find the Spotlight's action element in the document and in any potential ShadowDOM.