Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changeset reference not processed at beginning of bugnote #351

Closed
dregad opened this issue Jan 16, 2021 · 2 comments
Closed

Changeset reference not processed at beginning of bugnote #351

dregad opened this issue Jan 16, 2021 · 2 comments
Milestone

Comments

@dregad
Copy link
Member

dregad commented Jan 16, 2021

Given a bugnote with the following contents, Source Integration does not transform it into a link to the given commit.

c:repo:sha:

If the reference is preceded by whitespace, then it works properly

test c:repo:sha:
@dregad
Copy link
Member Author

dregad commented Jan 16, 2021

This is a follow-up of #204 - the updated regex (see commit 3dbec81) does not fully take into consideration the fact that the string received in SourcePlugin::display_formatted() has already been processed by the MantisCoreFormatting plugin.

The ^ in the regex's lookbehind intended to match the beginning of the string, does not work because in in the example above, the actual value of $p_text parameter is

<p>c:repo:sha</p>

So the character preceding the changeset reference is neither whitespace, nor the string's beginning so there is no match.

@dregad dregad added this to the 2.4.1 milestone Jan 23, 2021
@dregad
Copy link
Member Author

dregad commented Jan 23, 2021

This fix should have been committed separately, but was inadvertently included in c888810 (-> fixed in 2.4.1).

@dregad dregad closed this as completed Jan 23, 2021
dregad added a commit that referenced this issue Jan 23, 2021
- Reason for bumping minimum MantisBT version
- Added missing entry for #351 in 2.4.1 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant