Validate issue note type field

mantisbt · Jan 10, 2018 · 046dcb6 · 046dcb6
1 parent cf5df80
commit 046dcb6
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/core/commands/IssueNoteAddCommand.php b/core/commands/IssueNoteAddCommand.php
@@ -101,6 +101,20 @@ function __construct( array $p_data ) {
 	 * Validate the data.
 	 */
 	function validate() {
+		# Validate issue note type
+		switch( $this->payload( 'type', 'note' ) ) {
+			case 'note':
+			case 'timelog':
+				break;
+			case 'reminder':  # isn't supported by this command.
+			default:
+				throw new ClientException(
+					sprintf( "Invalid value '%s' for 'type'.", $t_type ),
+					ERROR_INVALID_FIELD_VALUE,
+					array( 'type' )
+				);
+		}
+
 		$t_issue_id = helper_parse_issue_id( $this->query( 'issue_id' ) );
 
 		$this->issue = bug_get( $t_issue_id, true );