Skip to content

Commit

Permalink
Fix required on resolve/close for custom fields
Browse files Browse the repository at this point in the history
If a custom field is marked as required on resolved or closed, it wasn't
enforced.  It was only enforced for the regular issue update page.

Fixes #20386
  • Loading branch information
vboctor committed Dec 18, 2015
1 parent ab91f9e commit 176169c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bug_update.php
Expand Up @@ -279,7 +279,7 @@
# If the custom field is not set and is required, then complain!
if( !gpc_isset_custom_field( $t_cf_id, $t_cf_def['type'] ) ) {
if( $t_cf_def[$t_cf_require_check] &&
$f_update_type == BUG_UPDATE_TYPE_NORMAL &&
custom_field_is_present( $t_cf_id ) &&
custom_field_has_write_access( $t_cf_id, $f_bug_id ) ) {
# A value for the custom field was expected however
# no value was given by the user.
Expand Down

0 comments on commit 176169c

Please sign in to comment.