Skip to content

Commit

Permalink
Add missing configs in manage workflow thresholds
Browse files Browse the repository at this point in the history
The add/remove monitors thresholds (monitor_add_others_bug_threshold,
monitor_add_others_bug_threshold) were not configurable via
manage_config_work_threshold_page.php

Fixes #25826
  • Loading branch information
dregad committed May 31, 2019
1 parent 1ef47af commit 1a73057
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 0 deletions.
10 changes: 10 additions & 0 deletions docbook/Admin_Guide/en-US/Page_Descriptions.xml
Expand Up @@ -787,6 +787,16 @@
<entry>$g_show_monitor_list_threshold</entry>
<entry>threshold to see who is monitoring an issue</entry>
</row>
<row>
<entry>Add monitors to an issue</entry>
<entry>$g_monitor_add_others_bug_threshold</entry>
<entry>threshold to add users to the list of users monitoring an issue</entry>
</row>
<row>
<entry>Remove monitors from an issue</entry>
<entry>$g_monitor_delete_others_bug_threshold</entry>
<entry>threshold to remove users from the list of users monitoring an issue</entry>
</row>
<row>
<entry>Set status on assignment of handler</entry>
<entry>$g_auto_set_status_to_assigned</entry>
Expand Down
2 changes: 2 additions & 0 deletions lang/strings_english.txt
Expand Up @@ -1433,6 +1433,8 @@ $s_update_issue_status = 'Update issue status';
$s_set_view_status = 'Set view state when reporting a new issue or note';
$s_update_view_status = 'Change view state of existing issue or note';
$s_show_list_of_users_monitoring_issue = 'Show list of users monitoring issue';
$s_add_users_monitoring_issue = 'Add monitors to an issue';
$s_remove_users_monitoring_issue = 'Remove monitors from an issue';
$s_notes = 'Notes';
$s_add_notes = 'Add notes';
$s_view_private_notes = 'View others\' private notes';
Expand Down
2 changes: 2 additions & 0 deletions manage_config_work_threshold_page.php
Expand Up @@ -390,6 +390,8 @@ function get_section_end() {
get_capability_row( lang_get( 'set_view_status' ), 'set_view_status_threshold' );
get_capability_row( lang_get( 'update_view_status' ), 'change_view_status_threshold' );
get_capability_row( lang_get( 'show_list_of_users_monitoring_issue' ), 'show_monitor_list_threshold' );
get_capability_row( lang_get( 'add_users_monitoring_issue' ), 'monitor_add_others_bug_threshold' );
get_capability_row( lang_get( 'remove_users_monitoring_issue' ), 'monitor_delete_others_bug_threshold' );
get_capability_boolean( lang_get( 'set_status_assigned' ), 'auto_set_status_to_assigned' );
get_capability_enum( lang_get( 'assigned_status' ), 'bug_assigned_status', 'status' );
get_capability_boolean( lang_get( 'limit_access' ), 'limit_reporters', true );
Expand Down
2 changes: 2 additions & 0 deletions manage_config_work_threshold_set.php
Expand Up @@ -174,6 +174,8 @@ function set_capability_enum( $p_threshold, $p_all_projects_only = false ) {
set_capability_row( 'set_view_status_threshold' );
set_capability_row( 'change_view_status_threshold' );
set_capability_row( 'show_monitor_list_threshold' );
set_capability_row( 'monitor_add_others_bug_threshold' );
set_capability_row( 'monitor_delete_others_bug_threshold' );
set_capability_boolean( 'auto_set_status_to_assigned' );
set_capability_enum( 'bug_assigned_status' );
set_capability_boolean( 'limit_reporters', true );
Expand Down

0 comments on commit 1a73057

Please sign in to comment.