Skip to content

Commit

Permalink
Remove incorrectly placed db_param_push()
Browse files Browse the repository at this point in the history
When db_query() is called without a parameter array, the db_param stack
is not popped automatically, so in this case the db_param_push was not
being popped after query execution.

Fixes #21649
  • Loading branch information
cproensa authored and dregad committed Aug 27, 2016
1 parent 768a7f8 commit 22c421e
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion core/category_api.php
Expand Up @@ -265,7 +265,6 @@ function category_remove_all( $p_project_id, $p_new_category_id = 0 ) {
$t_category_ids = join( ',', $t_category_ids );

# update bug history entries
db_param_push();
$t_query = 'SELECT id, category_id FROM {bug} WHERE category_id IN ( ' . $t_category_ids . ' )';
$t_result = db_query( $t_query );

Expand Down
1 change: 0 additions & 1 deletion core/custom_field_api.php
Expand Up @@ -731,7 +731,6 @@ function custom_field_get_ids() {
global $g_cache_cf_list, $g_cache_custom_field;

if( $g_cache_cf_list === null ) {
db_param_push();
$t_query = 'SELECT * FROM {custom_field} ORDER BY name ASC';
$t_result = db_query( $t_query );
$t_ids = array();
Expand Down
1 change: 0 additions & 1 deletion core/email_queue_api.php
Expand Up @@ -192,7 +192,6 @@ function email_queue_delete( $p_email_id ) {
* @return array
*/
function email_queue_get_ids() {
db_param_push();
$t_query = 'SELECT email_id FROM {email} ORDER BY email_id ASC';
$t_result = db_query( $t_query );

Expand Down

0 comments on commit 22c421e

Please sign in to comment.