Fix #11426: Time tracking stopwatch strings not translatable

The strings used for the old inbuilt time tracking stopwatch feature need to be translatable.
mantisbt · Jan 25, 2010 · 2f42c6a · 2f42c6a
1 parent 4beb15a
commit 2f42c6a
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 7 deletions.
diff --git a/bugnote_add_inc.php b/bugnote_add_inc.php
@@ -77,12 +77,17 @@
 		<?php echo lang_get( 'time_tracking' ) ?> (HH:MM)
 	</td>
 	<td>
-		<?php if ( config_get('time_tracking_stopwatch') && ON == config_get( 'use_javascript' )) { 
+		<?php if ( config_get( 'time_tracking_stopwatch' ) && config_get( 'use_javascript' ) ) { ?>
+		<script language="javascript">
+			var time_tracking_stopwatch_lang_start = "<?php echo lang_get( 'time_tracking_stopwatch_start' ) ?>";
+			var time_tracking_stopwatch_lang_stop = "<?php echo lang_get( 'time_tracking_stopwatch_stop' ) ?>";
+		</script>
+		<?php
 			html_javascript_link( 'time_tracking_stopwatch.js' );
 		?>
 		<input type="text" name="time_tracking" size="5" value="00:00" />
-		<input type="button" name="time_tracking_ssbutton" value="Start" onclick="time_tracking_swstartstop()" />
-		<input type="button" name="time_tracking_reset" value="R" onclick="time_tracking_swreset()" />
+		<input type="button" name="time_tracking_ssbutton" value="<?php echo lang_get( 'time_tracking_stopwatch_start' ) ?>" onclick="time_tracking_swstartstop()" />
+		<input type="button" name="time_tracking_reset" value="<?php echo lang_get( 'time_tracking_stopwatch_reset' ) ?>" onclick="time_tracking_swreset()" />
 		<?php } else { ?>
 		<input type="text" name="time_tracking" size="5" value="00:00" />
 		<?php } ?>

diff --git a/javascript/dev/time_tracking_stopwatch.js b/javascript/dev/time_tracking_stopwatch.js
@@ -6,19 +6,19 @@ function time_tracking_swstartstop() {
 		time_tracking_running = 1;
 		time_tracking_then = new Date();
 		time_tracking_then.setTime(time_tracking_then.getTime() - time_tracking_ms);
-		document.bugnoteadd.time_tracking_ssbutton.value = "Stop";
+		document.bugnoteadd.time_tracking_ssbutton.value = time_tracking_stopwatch_lang_stop;
 	} else {
 		time_tracking_running = 0;
 		time_tracking_now = new Date();
 		time_tracking_ms = time_tracking_now.getTime() - time_tracking_then.getTime();
-		document.bugnoteadd.time_tracking_ssbutton.value = "Start";
+		document.bugnoteadd.time_tracking_ssbutton.value = time_tracking_stopwatch_lang_start;
 	}
 }
 function time_tracking_swreset() {
 	time_tracking_running = 0;
 	time_tracking_ms = 0;
 	document.bugnoteadd.time_tracking.value = "0:00:00";
-	document.bugnoteadd.time_tracking_ssbutton.value = "Start";
+	document.bugnoteadd.time_tracking_ssbutton.value = time_tracking_stopwatch_lang_start;
 }
 
 function time_tracking_display() {

diff --git a/javascript/min/time_tracking_stopwatch.js b/javascript/min/time_tracking_stopwatch.js
diff --git a/lang/strings_english.txt b/lang/strings_english.txt
@@ -1506,6 +1506,9 @@ $s_time_tracking_get_info_button = 'Get Time Tracking Information';
 $s_time_tracking_cost_per_hour = 'Cost / Hour';
 $s_time_tracking_cost = 'Cost';
 $s_total_time_for_issue = 'Total time for issue = %1$s';
+$s_time_tracking_stopwatch_start = 'Start';
+$s_time_tracking_stopwatch_stop = 'Stop';
+$s_time_tracking_stopwatch_reset = 'Reset';
 
 $s_access_denied = 'Access Denied.';