Fixes #11427: Undefined index: id

Fix provided by vboctor, supplemented with a SOAP test.
mantisbt · Feb 26, 2010 · 44be8f3 · 44be8f3
1 parent db07af1
commit 44be8f3
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 5 deletions.
diff --git a/api/soap/mc_api.php b/api/soap/mc_api.php
@@ -101,12 +101,10 @@ function mci_get_project_view_state_id( $p_view_state ) {
 function mci_get_user_id( $p_user ) {
 	$t_user_id = 0;
 
-	if( (int) $p_user['id'] != 0 ) {
+	if ( isset( $p_user['id'] ) && (int) $p_user['id'] != 0 ) {
 		$t_user_id = (int) $p_user['id'];
-	} else {
-		if( isset( $p_user['name'] ) ) {
-			$t_user_id = user_get_id_by_name( $p_user['name'] );
-		}
+	} elseif ( isset( $p_user['name'] ) ) {
+		$t_user_id = user_get_id_by_name( $p_user['name'] );
 	}
 
 	return $t_user_id;

diff --git a/tests/soap/IssueAddTest.php b/tests/soap/IssueAddTest.php
@@ -355,4 +355,31 @@ public function testCreateIssueWithTimeTrackingNote() {
 			$this->password,
 			$issueId);
 	}
+
+	/**
+	 * This issue tests the following
+	 * 
+	 * 1. Creating an issue where the handler is given by name
+	 * 2. Retrieving the issue
+	 * 3. Verifying that the handler name is correctly set
+	 */
+	public function testCreateIssueWithHandlerByName() {
+
+		$issueToAdd = $this->getIssueToAdd( 'testCreateIssueWithHandlerByName' );
+		$issueToAdd['handler'] = array(
+			'name' => $this->userName
+		);
+
+		$issueId = $this->client->mc_issue_add(
+			$this->userName,
+			$this->password,
+			$issueToAdd);
+
+		$issue = $this->client->mc_issue_get(
+			$this->userName,
+			$this->password,
+			$issueId);
+
+		$this->assertEquals( $this->userName,  $issue->handler->name );
+	}
 }