Skip to content

Commit

Permalink
Fix #11236: XSS on view_all_bug_page.php with user Real Name field
Browse files Browse the repository at this point in the history
If a user is selected in one of the user filters (reporter, monitored
by, etc) and that user has a name containing HTML elements, the HTML
elements would not be escaped prior to displaying them as the currently
selected filter options.
  • Loading branch information
davidhicks committed Dec 1, 2009
1 parent 92561bc commit 4cb58c7
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions core/filter_api.php
Expand Up @@ -2217,7 +2217,7 @@ function filter_draw_selection_area2( $p_page_number, $p_for_screen = true, $p_e
if( true == $t_any_found ) {
echo lang_get( 'any' );
} else {
echo $t_output;
echo string_display( $t_output );
}
}
?>
Expand Down Expand Up @@ -2255,7 +2255,7 @@ function filter_draw_selection_area2( $p_page_number, $p_for_screen = true, $p_e
if( true == $t_any_found ) {
echo lang_get( 'any' );
} else {
echo $t_output;
echo string_display( $t_output );
}
}
?>
Expand Down Expand Up @@ -2294,7 +2294,7 @@ function filter_draw_selection_area2( $p_page_number, $p_for_screen = true, $p_e
if( true == $t_any_found ) {
echo lang_get( 'any' );
} else {
echo $t_output;
echo string_display( $t_output );
}
}
?>
Expand Down Expand Up @@ -3256,7 +3256,7 @@ function <?php echo $t_js_toggle_func;?>() {
if( true == $t_any_found ) {
echo lang_get( 'any' );
} else {
echo $t_output;
echo string_display( $t_output );
}
}
?>
Expand Down

0 comments on commit 4cb58c7

Please sign in to comment.