Skip to content

Commit

Permalink
Revert "Add 'Match type' to list of filter properties to validate"
Browse files Browse the repository at this point in the history
This reverts commit 5e12bf9 which
caused a regression (system notice when displaying the match type filter
criteria, or application error 203 when trying to apply the filter).

The change made match_type a multivalue property, which caused it to be
converted to an array by filter_ensure_valid_filter().

Issue #20105
  • Loading branch information
dregad committed Oct 29, 2015
1 parent 931c5cc commit 5a496d8
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion core/filter_api.php
Expand Up @@ -698,7 +698,6 @@ function filter_ensure_valid_filter( array $p_filter_arr ) {
FILTER_PROPERTY_TARGET_VERSION => 'string',
FILTER_PROPERTY_MONITOR_USER_ID => 'int',
FILTER_PROPERTY_PROFILE_ID => 'int',
FILTER_PROPERTY_MATCH_TYPE => 'int',
);
foreach( $t_multi_select_list as $t_multi_field_name => $t_multi_field_type ) {
if( !isset( $p_filter_arr[$t_multi_field_name] ) ) {
Expand Down

0 comments on commit 5a496d8

Please sign in to comment.