Documentation tweaks

api/rest/restcore/issues_rest.php

@@ -204,9 +204,6 @@ function rest_issue_note_add( \Slim\Http\Request $p_request, \Slim\Http\Response
 		}
 	}
 
-	# TODO: support reminder notes
-	# TODO: support note attachments
-
 	$t_command = new IssueNoteAddCommand( $t_data );
 	$t_command_response = $t_command->execute();
 

core/commands/Command.php

@@ -26,8 +26,12 @@
 abstract class Command
 {
 	/**
-	 * This is the payload data for the command.  Modelled after the REST
-	 * API, this should be the body of the request.
+	 * This is the data for the command.  Modelled after the REST
+	 * it has the following sub-arrays:
+	 * 'query' - an array of url and query string parameters.
+	 * 'payload' - the payload
+	 * 'options' - options specified by the internal codebase and not
+	 *             as part of the request.
 	 *
 	 * @var array The input data for the command.
 	 */

core/commands/IssueNoteAddCommand.php

@@ -109,6 +109,9 @@ function validate() {
 		switch( $this->payload( 'type', 'note' ) ) {
 			case 'note':
 			case 'timelog':
+				# nothing to do here, the command will always set the
+				# type to `note` and core API will set to `timelog`
+				# when appropriate.
 				break;
 			case 'reminder':  # isn't supported by this command.
 			default:
@@ -285,9 +288,9 @@ private function parseFiles() {
 		$t_files_required_fields = array();
 
 		$t_files_required_fields = array( 'name', 'tmp_name' );
-		for( $i = 0; $i < count( $this->files ); $i++ ) {
+		foreach( $this->files as $t_file ) {
 			foreach( $t_files_required_fields as $t_field ) {
-				if( !isset( $this->files[$i][$t_field] ) ) {
+				if( !isset( $t_file[$t_field] ) ) {
 					throw new ClientException(
 						sprintf( "File field '%s' is missing.", $t_field ),
 						ERROR_EMPTY_FIELD,