Skip to content

Commit

Permalink
Issue #10859: Add hyperlinks for bugnote IDs
Browse files Browse the repository at this point in the history
To make it easier to reference bugnotes externally (in emails, IRC,
etc), bugnote IDs on the bug view page should be hyperlinked to match
the existing anchor for each bugnote.

Note that bug_view_inc.php is included by other scripts (such as when
one attempts to update a bug). For this reason, view.php is always used
when creating the bugnote hyperlink, as it doesn't make sense to send an
external user to a bug update page, just so they can view a bugnote.

Signed-off-by: David Hicks <hickseydr@optusnet.com.au>
  • Loading branch information
Christian Weiske authored and davidhicks committed Aug 21, 2009
1 parent e58acd9 commit 75afc10
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion bugnote_view_inc.php
Expand Up @@ -112,7 +112,7 @@
<tr class="bugnote" id="c<?php echo $t_bugnote->id ?>">
<td class="<?php echo $t_bugnote_css ?>">
<?php if ( ON == config_get("show_avatar") ) print_avatar( $t_bugnote->reporter_id ); ?>
<span class="small">(<?php echo $t_bugnote_id_formatted ?>)</span><br />
<span class="small">(<a href="<?php echo string_get_bugnote_view_url($t_bugnote->bug_id, $t_bugnote->id) ?>" title="<?php echo lang_get( 'bugnote_link_title' ) ?>"><?php echo $t_bugnote_id_formatted ?>)</a></span><br />
<?php
echo print_user( $t_bugnote->reporter_id );
?>
Expand Down
1 change: 1 addition & 0 deletions lang/strings_english.txt
Expand Up @@ -89,6 +89,7 @@ $s_bug_monitor = 'Issue Monitored';
$s_bug_end_monitor = 'Issue End Monitor';
$s_announcement = 'Announcement';
$s_stays_on_top = 'Stays on Top';
$s_bugnote_link_title = 'Direct link to note';
$s_delete_bugnote_button = 'Delete Note';
$s_delete_bugnote_sure_msg = 'Are you sure you wish to delete this note?';
$s_bug_relationships = 'Relationships';
Expand Down

0 comments on commit 75afc10

Please sign in to comment.