Use disposable-email-checker v3 via Composer

Fixes #22913

.gitmodules

@@ -6,10 +6,6 @@
 	path = library/phpmailer
 	url = https://github.com/mantisbt/PHPMailer
 	branch = mantis
-[submodule "library/disposable"]
-	path = library/disposable
-	url = https://github.com/mantisbt/disposable_email_checker
-	branch = mantisbt
 [submodule "library/securimage"]
 	path = library/securimage
 	url = https://github.com/mantisbt/securimage.git

composer.json

@@ -4,7 +4,8 @@
     "type": "project",
     "require": {
         "slim/slim": "^3.0",
-        "guzzlehttp/guzzle": "^6.2"
+        "guzzlehttp/guzzle": "^6.2",
+        "vboctor/disposable_email_checker": "^3.0"
     },
     "license": "GPL v2",
     "authors": [

core.php

@@ -67,6 +67,9 @@
 
 ob_start();
 
+# Load Composer autoloader
+require_once( dirname( __FILE__ ) . DIRECTORY_SEPARATOR . 'vendor/autoload.php' );
+
 # Load supplied constants
 require_once( dirname( __FILE__ ) . DIRECTORY_SEPARATOR . 'core' . DIRECTORY_SEPARATOR . 'constant_inc.php' );
 

core/email_api.php

@@ -196,11 +196,7 @@ function email_ensure_valid( $p_email ) {
  * @return boolean
  */
 function email_is_disposable( $p_email ) {
-	if( !class_exists( 'DisposableEmailChecker' ) ) {
-		require_lib( 'disposable/disposable.php' );
-	}
-
-	return DisposableEmailChecker::is_disposable_email( $p_email );
+	return \VBoctor\Email\DisposableEmailChecker::is_disposable_email( $p_email );
 }
 
 /**

library/README.md

@@ -10,7 +10,6 @@ The version and status of each is summarized below:
 directory       | project         | version   | status
 ----------------|-----------------|-----------|---------------
 adodb           | adodb           | 5.20.9    | unpatched [1]
-disposable      | disposable      | 2.1.1     | unpatched [1]
 parsedown       | parsedown       | 1.6.1     | unpatched [1]
 phpmailer       | PHPMailer       | 5.2.22    | unpatched [1]
 rssbuilder      | RSSBuilder      | 2.2.1     | patched [2]
@@ -47,7 +46,6 @@ Upstream projects
 project         | URL
 ----------------|--------------------------------------------------------------------
 adodb           | http://adodb.sourceforge.net/ - https://github.com/ADOdb/ADOdb
-disposable      | http://github.com/vboctor/disposable_email_checker
 parsedown       | https://github.com/erusev/parsedown
 phpmailer       | https://github.com/PHPMailer/PHPMailer
 rssbuilder      | http://code.google.com/p/flaimo-php/

scripts/travis_before_script.sh

@@ -130,6 +130,9 @@ chmod 777 config
 #  wait until server is up
 sleep 10
 
+# -----------------------------------------------------------------------------
+step "Install Composer Components"
+composer install
 
 # -----------------------------------------------------------------------------
 step "MantisBT Installation"