Skip to content

Commit

Permalink
Fix #3064: view bug buttons in vertical column
Browse files Browse the repository at this point in the history
Many browsers go to the next line when you start a form.  The only way to ensure they're on the same line is to put them each in their own table cell.  If we want them to be close together and centered then they need to go into a table inside the main table cell.  There may be another way to do this with CSS but I'm not going to spend time on it right now.

* bug_view_advanced_page.php:
* bug_view_page.php:
  use align="center" instead of class="center"
  since the css version doesn't seem to work when the td has a table as its contents?

* core/html_api.php:
  (html_buttons_view_bug_page): put each button in its own td and put
  the whole thing inside a table.


git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@2125 f5dc347c-c33d-0410-90a0-b07cc1902cb9
  • Loading branch information
Julian Fitzell committed Mar 24, 2003
1 parent 1a741b7 commit 7edff30
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 6 deletions.
4 changes: 2 additions & 2 deletions bug_view_advanced_page.php
Expand Up @@ -6,7 +6,7 @@
# See the README and LICENSE files for details

# --------------------------------------------------------
# $Id: bug_view_advanced_page.php,v 1.44 2003-03-10 18:14:08 jfitzell Exp $
# $Id: bug_view_advanced_page.php,v 1.45 2003-03-24 06:26:41 jfitzell Exp $
# --------------------------------------------------------
?>
<?php
Expand Down Expand Up @@ -480,7 +480,7 @@

<!-- Buttons -->
<tr align="center">
<td class="center" colspan="6">
<td align="center" colspan="6">
<?php
html_buttons_view_bug_page( $f_bug_id );
?>
Expand Down
4 changes: 2 additions & 2 deletions bug_view_page.php
Expand Up @@ -6,7 +6,7 @@
# See the README and LICENSE files for details

# --------------------------------------------------------
# $Id: bug_view_page.php,v 1.45 2003-03-10 18:14:10 jfitzell Exp $
# $Id: bug_view_page.php,v 1.46 2003-03-24 06:26:42 jfitzell Exp $
# --------------------------------------------------------
?>
<?php
Expand Down Expand Up @@ -393,7 +393,7 @@

<!-- Buttons -->
<tr align="center">
<td class="center" colspan="6">
<td align="center" colspan="6">
<?php
html_buttons_view_bug_page( $f_bug_id );
?>
Expand Down
14 changes: 13 additions & 1 deletion core/html_api.php
Expand Up @@ -6,7 +6,7 @@
# See the README and LICENSE files for details

# --------------------------------------------------------
# $Id: html_api.php,v 1.71 2003-03-22 16:30:36 jlatour Exp $
# $Id: html_api.php,v 1.72 2003-03-24 06:26:42 jfitzell Exp $
# --------------------------------------------------------

###########################################################################
Expand Down Expand Up @@ -707,31 +707,43 @@ function html_buttons_view_bug_page( $p_bug_id ) {
$t_resolved = config_get( 'bug_resolved_status_threshold' );
$t_status = bug_get_field( $p_bug_id, 'status' );

echo '<table><tr><td>';
if ( $t_status < $t_resolved ) {
# UPDATE button
html_button_bug_update( $p_bug_id );

echo '</td><td>';

# ASSIGN button
html_button_bug_assign( $p_bug_id );

echo '</td><td>';

# RESOLVE button
html_button_bug_resolve( $p_bug_id );
} else {
# REOPEN button
html_button_bug_reopen( $p_bug_id );
}
echo '</td>';

# CLOSE button
echo '<td>';
html_button_bug_close( $p_bug_id );
echo '</td>';

# MONITOR/UNMONITOR button
echo '<td>';
if ( user_is_monitoring_bug( auth_get_current_user_id(), $p_bug_id ) ) {
html_button_bug_unmonitor( $p_bug_id );
} else {
html_button_bug_monitor( $p_bug_id );
}
echo '</td>';

# DELETE button
echo '<td>';
html_button_bug_delete( $p_bug_id );
echo '</td></tr></table>';
}
?>
3 changes: 2 additions & 1 deletion doc/ChangeLog
Expand Up @@ -4,7 +4,8 @@ Mantis ChangeLog

* Fix: Improved adherance to the XHTML standard.
* Fix #3072: Attached file should be opened up in a new browser window.

* Fix #3064: view bug buttons in vertical column

2003.03.22 - 0.18.0a4

* Check whether other forms of compression are enabled before we turn on ob_gzhandler() in our output handler. This should hopefully avoid problems people have had with blank pages resulting from compression problems.
Expand Down

0 comments on commit 7edff30

Please sign in to comment.