Skip to content

Commit

Permalink
Fix #11530: Don't expose real name and email of higher users
Browse files Browse the repository at this point in the history
manage_user_threshold grants permission to users so that they can modify
user accounts which have an equal or lower access level.

Therefore we shouldn't be exposing the real name and email of users on
view_user_page.php if the target user has a higher access level. The
manage user link should also not appear when the target user has a
higher access level.
  • Loading branch information
davidhicks committed Apr 1, 2010
1 parent 886dccd commit 86fc322
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions view_user_page.php
Expand Up @@ -28,17 +28,18 @@

auth_ensure_user_authenticated();

$t_can_manage = access_has_global_level( config_get( 'manage_user_threshold' ) );
$t_can_see_realname = access_has_project_level( config_get( 'show_user_realname_threshold' ) );
$t_can_see_email = access_has_project_level( config_get( 'show_user_email_threshold' ) );

# extracts the user information for the currently logged in user
# and prefixes it with u_
$f_user_id = gpc_get_int( 'id', auth_get_current_user_id() );
$row = user_get_row( $f_user_id );

extract( $row, EXTR_PREFIX_ALL, 'u' );

$t_can_manage = access_has_global_level( config_get( 'manage_user_threshold' ) ) &&
access_has_global_level( $u_access_level );
$t_can_see_realname = access_has_project_level( config_get( 'show_user_realname_threshold' ) );
$t_can_see_email = access_has_project_level( config_get( 'show_user_email_threshold' ) );

# In case we're using LDAP to get the email address... this will pull out
# that version instead of the one in the DB
$u_email = user_get_email( $u_id );
Expand Down

0 comments on commit 86fc322

Please sign in to comment.