REST API PATCH /issue/:id now fails with HTTP 400

Previously, PHP warnings would be triggered when the payload is empty. Fixes #27973
mantisbt · Feb 20, 2021 · 9807fa2 · 9807fa2
1 parent f2ee0a6
commit 9807fa2
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/api/rest/restcore/issues_rest.php b/api/rest/restcore/issues_rest.php
@@ -368,6 +368,9 @@ function rest_issue_update( \Slim\Http\Request $p_request, \Slim\Http\Response $
 
 	# Construct full issue from issue from db + patched info
 	$t_issue_patch = $p_request->getParsedBody();
+	if( !$t_issue_patch ) {
+		return $p_response->withStatus( HTTP_STATUS_BAD_REQUEST, "Invalid request body or format");
+	}
 	if( isset( $t_issue_patch['id'] ) && $t_issue_patch['id'] != $t_issue_id ) {
 		return $p_response->withStatus( HTTP_STATUS_BAD_REQUEST, 'Issue id mismatch' );
 	}