Build a default filter only when needed

Check returned value and build a default filter only when needed.
mantisbt · Mar 4, 2018 · b55c7e1 · b55c7e1
1 parent 820d6ca
commit b55c7e1
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/core/current_user_api.php b/core/current_user_api.php
@@ -239,7 +239,11 @@ function current_user_get_bug_filter( $p_project_id = null ) {
 	$f_tmp_key = gpc_get_string( 'filter', null );
 
 	if( null !== $f_tmp_key ) {
-		$t_filter = filter_temporary_get( $f_tmp_key, filter_get_default() );
+		$t_filter = filter_temporary_get( $f_tmp_key, null );
+		# if filter doesn't exist or can't be loaded, return a default filter (doesn't throw error)
+		if( null === $t_filter ) {
+			$t_filter = filter_get_default();
+		}
 	} else {
 		$t_user_id = auth_get_current_user_id();
 		$t_filter = user_get_bug_filter( $t_user_id, $p_project_id );