Skip to content

Commit

Permalink
complete the fix for 0004602: Mismatch between Assign To dropdown and…
Browse files Browse the repository at this point in the history
… Assigned To whil updating

added a check for access rights for the handler after the status is set


git-svn-id: http://mantisbt.svn.sourceforge.net/svnroot/mantisbt/trunk@3012 f5dc347c-c33d-0410-90a0-b07cc1902cb9
  • Loading branch information
thraxisp committed Sep 28, 2004
1 parent 39644ad commit b8b35d1
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
7 changes: 6 additions & 1 deletion bug_update.php
Expand Up @@ -6,7 +6,7 @@
# See the README and LICENSE files for details

# --------------------------------------------------------
# $Id: bug_update.php,v 1.70 2004-09-04 05:06:03 thraxisp Exp $
# $Id: bug_update.php,v 1.71 2004-09-28 14:09:39 thraxisp Exp $
# --------------------------------------------------------
?>
<?php
Expand Down Expand Up @@ -73,6 +73,11 @@

helper_call_custom_function( 'issue_update_validate', array( $f_bug_id, $t_bug_data ) );

# check that handler has access level to handle the bug
if ( ! access_has_project_level( access_get_status_threshold( $t_bug_data->status,
$t_bug_data->project_id ), $t_bug_data->project_id, $t_bug_data->handler_id ) ) {
trigger_error( ERROR_HANDLER_ACCESS_TOO_LOW, ERROR );
}

$t_custom_status_label = "update"; # default info to check
if ( $t_bug_data->status == config_get( 'bug_resolved_status_threshold' ) ) {
Expand Down
3 changes: 2 additions & 1 deletion core/constant_inc.php
Expand Up @@ -6,7 +6,7 @@
# See the README and LICENSE files for details

# --------------------------------------------------------
# $Id: constant_inc.php,v 1.30 2004-09-22 10:03:42 bpfennigschmidt Exp $
# $Id: constant_inc.php,v 1.31 2004-09-28 14:09:39 thraxisp Exp $
# --------------------------------------------------------

### CONSTANTS ###
Expand Down Expand Up @@ -163,6 +163,7 @@
define( 'ERROR_ACCESS_DENIED', 13 );
define( 'ERROR_UPLOAD_FAILURE', 15 );
define( 'ERROR_FTP_CONNECT_ERROR', 16 );
define( 'ERROR_HANDLER_ACCESS_TOO_LOW', 17 );

# ERROR_CONFIG_*
define( 'ERROR_CONFIG_OPT_NOT_FOUND', 100 );
Expand Down
7 changes: 4 additions & 3 deletions lang/strings_english.txt
Expand Up @@ -9,11 +9,11 @@
###########################################################################
# English strings for Mantis
# -------------------------------------------------
# $Revision: 1.214 $
# $Revision: 1.215 $
# $Author: thraxisp $
# $Date: 2004-09-28 13:57:38 $
# $Date: 2004-09-28 14:09:40 $
#
# $Id: strings_english.txt,v 1.214 2004-09-28 13:57:38 thraxisp Exp $
# $Id: strings_english.txt,v 1.215 2004-09-28 14:09:40 thraxisp Exp $
###########################################################################
?>
<?php
Expand Down Expand Up @@ -185,6 +185,7 @@ $MANTIS_ERROR[ERROR_BUGNOTE_NOT_FOUND] = 'Note not found.';
$MANTIS_ERROR[ERROR_PROJECT_NOT_FOUND] = 'Project not found.';
$MANTIS_ERROR[ERROR_DB_FIELD_NOT_FOUND] = 'Database field \'%s\' not found.';
$MANTIS_ERROR[ERROR_FTP_CONNECT_ERROR] = 'Unable to connect to FTP server.';
$MANTIS_ERROR[ERROR_HANDLER_ACCESS_TOO_LOW] = 'Issue handler does not have sufficient access rights to handle issue at this status.';
$MANTIS_ERROR[ERROR_PROJECT_NAME_NOT_UNIQUE] = 'A project with that name already exists. Please go back and enter a different name.';
$MANTIS_ERROR[ERROR_PROJECT_NAME_INVALID] = 'Invalid project name specified. Project names cannot be blank.';
$MANTIS_ERROR[ERROR_USER_NOT_FOUND] = 'User not found.';
Expand Down

0 comments on commit b8b35d1

Please sign in to comment.