Use ':' as separator in collapse_settings cookie

Previously we were using a comma, which is not a valid character in a cookie (per RFC6265 section 4.1.1 [1]). Fixes #20822 [1] http://tools.ietf.org/html/rfc6265#section-4.2.1 [^]
mantisbt · Apr 18, 2016 · e3956c2 · e3956c2
1 parent d4d4257
commit e3956c2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/core/collapse_api.php b/core/collapse_api.php
@@ -209,7 +209,7 @@ function collapse_cache_token() {
 		$t_data = explode( '|', $t_cookie );
 
 		foreach( $t_data as $t_pair ) {
-			$t_pair = explode( ',', $t_pair );
+			$t_pair = explode( ':', $t_pair );
 
 			if( false !== $t_pair && count( $t_pair ) == 2 ) {
 				$g_collapse_cache_token[$t_pair[0]] = ( true == $t_pair[1] );

diff --git a/js/common.js b/js/common.js
@@ -389,9 +389,9 @@ function ToggleDiv( p_div ) {
 	}
 
 	if ( t_open_display == "none" ) {
-		t_cookie = t_cookie + "|" + p_div + ",1";
+		t_cookie = t_cookie + "|" + p_div + ":1";
 	} else {
-		t_cookie = t_cookie + "|" + p_div + ",0";
+		t_cookie = t_cookie + "|" + p_div + ":0";
 	}
 
 	SetCookie( "collapse_settings", t_cookie );