Fix XSS in bug_actiongroup.php

Issue summary was printed on bug_actiongroup.php without being sanitized (CVE-2018-14895). Fixes #24647
mantisbt · Aug 6, 2018 · e819735 · e819735
1 parent cf5c23f
commit e819735
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/bug_actiongroup.php b/bug_actiongroup.php
@@ -353,7 +353,8 @@
 	$separator = lang_get( 'word_separator' );
 	foreach( $t_failed_ids as $t_id => $t_reason ) {
 		$label = sprintf( lang_get( 'label' ), string_get_bug_view_link( $t_id ) ) . $separator;
-		printf( "<tr><td width=\"50%%\">%s%s</td><td>%s</td></tr>\n", $label, bug_get_field( $t_id, 'summary' ), $t_reason );
+		$t_summary = string_display_line( bug_get_field( $t_id, 'summary' ) );
+		printf( "<tr><td width=\"50%%\">%s%s</td><td>%s</td></tr>\n", $label, $t_summary, $t_reason );
 	}
 	echo '</div>';
 	echo '</table><br />';