BugFilterQuery check for later modifications

The internal sql query is built and ready after the constructor method,
and regenerated after changing query type with set_query_type().
However, if externally adding clauses throguh add_join(), add_where(),
etc, those new parts are not translated to the final query
automatically.

Add a flag that keeps track of the modified state, so if the query is
executed after modifications, the internal sql is rebuilt.

Fixes: #24600

core/classes/BugFilterQuery.class.php

@@ -86,6 +86,13 @@
  *   $main_query = new DbQuery( 'SELECT * FROM {bug} WHERE id IN :filter_ids' );
  *   $main_query->bind( 'filter_ids', $subquery );
  *   $main_query->execute();
+ *
+ * Right after the BugFilterQuery object is created, all the internal query parts
+ * are constructed based on the filter, and the actual DbQuery sql is built based
+ * on the query type.
+ * If at a later time, externally new parts are added (where, join, order, etc),
+ * the actual sql will be rebuilt once the DbQuery 'execute' method is used, or
+ * build_query() is explicitly called.
  */
 
 class BugFilterQuery extends DbQuery {
@@ -102,6 +109,7 @@ class BugFilterQuery extends DbQuery {
 	public $use_sticky;
 
 	# internal storage for intermediate data
+	protected $query_type;
 	protected $parts_select = array();
 	protected $parts_from = array();
 	protected $parts_join = array();
@@ -115,6 +123,7 @@ class BugFilterQuery extends DbQuery {
 	protected $rt_included_projects;
 	protected $rt_table_alias_cf;
 	protected $table_alias_bugnote = null;
+	protected $needs_rebuild;
 
 	/**
 	 * Constructor.
@@ -174,6 +183,8 @@ public function __construct( $p_filter, $p_config = self::QUERY_TYPE_LIST ) {
 		} else {
 			$t_query_type = $p_config;
 		}
+		$this->query_type = $t_query_type;
+		$this->needs_rebuild = true;
 
 		# The query string must be built here to have a valid DbQuery object ready for use
 		$this->build_main();
@@ -191,7 +202,17 @@ public function __construct( $p_filter, $p_config = self::QUERY_TYPE_LIST ) {
 	 * @return void
 	 */
 	public function set_query_type( $p_query_type ) {
-		switch( $p_query_type ) {
+		$this->query_type = (int)$p_query_type;
+		$this->build_query();
+	}
+
+	/**
+	 * Builds the actual DbQuery object based on the current query type and query parts
+	 *
+	 * @return void
+	 */
+	public function build_query() {
+		switch( $this->query_type ) {
 			case self::QUERY_TYPE_COUNT:
 				$this->sql( $this->string_query_count() );
 				break;
@@ -206,9 +227,26 @@ public function set_query_type( $p_query_type ) {
 				$this->sql( $this->string_query_list() );
 				break;
 		}
+		$this->needs_rebuild = false;
 		$this->db_result = null;
 	}
 
+	/**
+	 * Override DbQuery execute method to check first if the query is already buils and up to date
+	 * with current query parts.
+	 *
+	 * @param array $p_bind_array	Array for binding values
+	 * @param integer $p_limit		Limit value
+	 * @param integer $p_offset		Offset value
+	 * @return IteratorAggregate|boolean ADOdb result set or false if the query failed.
+	 */
+	public function execute( array $p_bind_array = null, $p_limit = null, $p_offset = null ) {
+		if( $this->needs_rebuild ) {
+			$this->build_query();
+		}
+		return parent::execute( $p_bind_array, $p_limit, $p_offset );
+	}
+
 	/**
 	 * Shorthand method to get the total number of issues matched by the filter
 	 * It creates a copy of current object, set its type to a count query,
@@ -236,6 +274,7 @@ public function get_bug_count() {
 	 */
 	public function add_select( $p_string ) {
 		$this->parts_select[] = $p_string;
+		$this->needs_rebuild = true;
 	}
 
 	/**
@@ -245,6 +284,7 @@ public function add_select( $p_string ) {
 	 */
 	public function add_from( $p_string ) {
 		$this->parts_from[] = $p_string;
+		$this->needs_rebuild = true;
 	}
 
 	/**
@@ -254,6 +294,7 @@ public function add_from( $p_string ) {
 	 */
 	public function add_join( $p_string ) {
 		$this->parts_join[] = $p_string;
+		$this->needs_rebuild = true;
 	}
 
 	/**
@@ -264,6 +305,7 @@ public function add_join( $p_string ) {
 	 */
 	public function add_where( $p_string ) {
 		$this->parts_where[] = $p_string;
+		$this->needs_rebuild = true;
 	}
 
 	/**
@@ -274,6 +316,7 @@ public function add_where( $p_string ) {
 	 */
 	public function add_fixed_where( $p_string ) {
 		$this->fixed_where[] = $p_string;
+		$this->needs_rebuild = true;
 	}
 
 	/**
@@ -283,6 +326,7 @@ public function add_fixed_where( $p_string ) {
 	 */
 	public function add_order( $p_string ) {
 		$this->parts_order[] = $p_string;
+		$this->needs_rebuild = true;
 	}
 
 	/**