Update SOAP API to use VersionUpdateCommand

Fixes #30415
mantisbt · Apr 28, 2023 · ef791ad · ef791ad
1 parent f966247
commit ef791ad
Showing 1 changed file with 15 additions and 28 deletions.
diff --git a/api/soap/mc_project_api.php b/api/soap/mc_project_api.php
@@ -524,36 +524,23 @@ function mc_project_version_update( $p_username, $p_password, $p_version_id, std
 		return mci_fault_access_denied( $t_user_id );
 	}
 
-	if( !mci_has_access( config_get( 'manage_project_threshold' ), $t_user_id, $t_project_id ) ) {
-		return mci_fault_access_denied( $t_user_id );
-	}
-
-	if( is_blank( $t_name ) ) {
-		return ApiObjectFactory::faultBadRequest( 'Mandatory field "name" was missing' );
-	}
-
-	# check for duplicates
-	$t_old_version_name = version_get_field( $p_version_id, 'version' );
-	if( ( strtolower( $t_old_version_name ) != strtolower( $t_name ) ) && !version_is_unique( $t_name, $t_project_id ) ) {
-		return ApiObjectFactory::faultConflict( 'Version exists for project' );
-	}
-
-	if( $t_released === false ) {
-		$t_released = VERSION_FUTURE;
-	} else {
-		$t_released = VERSION_RELEASED;
-	}
+	$t_data = array(
+		'query' => array(
+			'project_id' => $t_project_id,
+			'version_id' => $p_version_id
+		),
+		'payload' => array(
+			'name' => $t_name,
+			'description' => $t_description,
+			'released' => $t_released,
+			'obsolete' => $t_obsolete,
+			'timestamp' => $t_date_order
+		)
+	);
 
-	$t_version_data = new VersionData();
-	$t_version_data->id = $p_version_id;
-	$t_version_data->project_id = $t_project_id;
-	$t_version_data->version = $t_name;
-	$t_version_data->description = $t_description;
-	$t_version_data->released = $t_released;
-	$t_version_data->date_order = $t_date_order;
-	$t_version_data->obsolete = $t_obsolete;
+	$t_command = new VersionUpdateCommand( $t_data );
+	$t_command->execute();
 
-	version_update( $t_version_data );
 	return true;
 }