Changes for print_form_button() #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: configuration report page
After adding margin
After adding visibility on hover (row):
|
dregad
requested changes
May 16, 2017
yes.. as i see the changes are likely to be discussed and changed, dind't put the "fixes..." right away. |
syncguru
approved these changes
May 29, 2017
| @@ -199,7 +199,7 @@ | |||
| ?> | |||
| <div class="clearfix"></div> | |||
| <div class="space-2"></div> | |||
| <div class="btn-group-sm"> | |||
| <div class="btn-group visible-on-hover"> | |||
There was a problem hiding this comment.
It is not very clear to me if removing "-sm" is intentional. If so, why?
There was a problem hiding this comment.
two reasons:
- other buttons in the pages are within plain "btn-group"
- to make it apply the margins with the defined css selector:
.btn-group .single-button-form.
Otherwise, the selector should be repeated for every .btn-group-xx
What do you think?
cproensa
force-pushed
the
print_form_button
branch
2 times, most recently
from
5a7d880
to
59f9f11
Compare
Rebased, and added the bug references in the commits |
dregad
approved these changes
Aug 14, 2017
Use 'button' tag instead of 'input', to offer better customization for labels and icons.
Add inline class to single button forms. Now it should not be needed to "pull-left" to place several buttons in line. Fixes: #22871
Add margin between buttons generated by print_form_button(), to be consistent with the general styling of inline buttons in a general form. Fixes: #22870
Make some buttons visible only when hovering over it's container. Applied to: adm_config_report.php, view.php (bugnotes) Fixes: #22872
dregad
force-pushed
the
print_form_button
branch
from
59f9f11
to
b0c652f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some proposals for buttons generated from print_form_button(), and buttons layout in general.
buttontag, instead ofinput, as the former can include icons. We use intensively these buttons in manage pages, one or several in each row of a table. Having the full text for all buttons add clutter to the page, so at some point they could be changed to icons