Cache all needed projects for navbar layout #1156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce DB query count by caching all needed projects for the navbar layout. Fixes: #23237
cproensa
force-pushed
the
0023237_cache_projects
branch
from
7c4bede
to
183763e
Compare
|
Added a second commit, where view_all_bug_page may read the project rows as part of the filter query, before the layout for navbar is done. |
The projects will be used to check access level, that will require reading the project rows from database. Making sure the projects rows are cached avoids having individual queries later for each project.
vboctor
approved these changes
Aug 17, 2017
core/filter_api.php
Outdated
| @@ -1492,6 +1492,7 @@ function filter_get_bug_rows_query_clauses( array $p_filter, $p_project_id = nul | |||
| $t_private_and_public_project_ids = array(); | |||
| $t_limited_projects = array(); | |||
|
|
|||
| project_cache_array_rows( $t_project_ids ); | |||
There was a problem hiding this comment.
It would be good to add the comments about why this is called, similar to the comment in the commit message.
dregad
approved these changes
Aug 17, 2017
cproensa
force-pushed
the
0023237_cache_projects
branch
from
2a16362
to
cce047c
Compare
|
@atrol seems like this PR has been merged, but not closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce DB query count by caching all needed projects for the navbar layout.
Fixes: #23237
After:
Before:
