Optimize summary queries #1479
Merged
Optimize summary queries #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested mariadb, mysql, pgsql and oracle |
cproensa
force-pushed
the
optimize_summary_queries
branch
from
98ab574
to
754ff62
Compare
The query for issues time stats is based on bug history, and history queries are expensive when scanning a lot of issues. The previous query retrieves all individual times for each issue, and then processes all the rows to find the maximum, average, etc. This processing, for a big number of issues, adds a considerable time to the function execution. With this change: - Introduce a database api check to know if window functions (analytic) are supported by current database. - When window functions are availabe, perform a query that computes the aggregated values by itself. The result is now only one row. - When window functions are not available, perform the simple, non aggregated query as before. The time cost for the windowed query is very similar to the previous version, but it improves: - No postprocessing time. - By returning one row, it can be effectively cached by the database, and further reduce times in succesive page loads.
Summary queries for bug history are the most expensive queries. Rewrite the queries for open/resolve count to be performed in a single query.
dregad
force-pushed
the
optimize_summary_queries
branch
from
754ff62
to
0abb605
Compare
|
@cproensa Do you have an issue in the bugtracker for this ? |
|
Opened #25693 to track this. |
dregad
approved these changes
Apr 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further improvements for summary page performance, targeting queries that use bug history table.
To put the recent changes of summary page in perspective:
my locally measured times, in a summary page for 50k issues.
MariaDB 10.3
Fixes #25693