Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 23694 #1502

Closed

Conversation

AnatolyKabakov1983
Copy link

@dregad
Copy link
Member

dregad commented Apr 12, 2019

Thanks for your contribution.

After reviewing the PR, I came to the conclusion that function print_bracket_link_prepared() should be left unchanged, and marked as obsolete. As of this writing, the only usage of this function in the MantisBT codebase, is when processing the EVENT_MENU_ISSUE hook in bug_view_inc.php.

The correct way of preventing links to be wrapped with [ ] in this context, is to change the plugin hook to return an associative array of the form label => link_target, instead of cooked links.

I will provide an alternative PR.

@dregad dregad closed this Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants