Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attachments when notes are private by default #1636

Merged
merged 1 commit into from Apr 2, 2020
Merged

Fix attachments when notes are private by default #1636

merged 1 commit into from Apr 2, 2020

Conversation

vboctor
Copy link
Member

@vboctor vboctor commented Mar 23, 2020

Fixes #26805

@vboctor
Fix attachments when notes are private by default
3b87a0c 
Fixes #26805

Signed-off-by: Victor Boctor <victor@mantishub.net>
@vboctor vboctor self-assigned this Mar 23, 2020
@atrol
Copy link
Member

atrol commented Mar 23, 2020

No need for an additional PR as there is already a fix for it in PR #1606

@vboctor
Copy link
Member Author

vboctor commented Mar 23, 2020

@atrol I think this current PR should be targeted for 2.24.1 and #1606 targeted for 2.25.0.

@vboctor
Copy link
Member Author

vboctor commented Apr 1, 2020

@atrol are you ok with this?

dregad
dregad approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@dregad dregad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me

@atrol
Copy link
Member

atrol commented Apr 1, 2020

@atrol are you ok with this?

I am.
I wanted to be sure that other devs are aware of the other open PR where we might get merge conflicts after this change.

@dregad dregad merged commit 65d47df into mantisbt:master-2.24 Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrol atrol atrol approved these changes

@dregad dregad dregad approved these changes

Assignees

@vboctor vboctor

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@vboctor @atrol @dregad