Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attachments when notes are private by default #1636

Merged

Conversation

@vboctor
Copy link
Member

vboctor commented Mar 23, 2020

Fixes #26805

Fixes #26805

Signed-off-by: Victor Boctor <victor@mantishub.net>
@vboctor vboctor self-assigned this Mar 23, 2020
@atrol

This comment has been minimized.

Copy link
Member

atrol commented Mar 23, 2020

No need for an additional PR as there is already a fix for it in PR #1606

@vboctor

This comment has been minimized.

Copy link
Member Author

vboctor commented Mar 23, 2020

@atrol I think this current PR should be targeted for 2.24.1 and #1606 targeted for 2.25.0.

@vboctor

This comment has been minimized.

Copy link
Member Author

vboctor commented Apr 1, 2020

@atrol are you ok with this?

@dregad
dregad approved these changes Apr 1, 2020
Copy link
Member

dregad left a comment

Fine with me

@atrol

This comment has been minimized.

Copy link
Member

atrol commented Apr 1, 2020

@atrol are you ok with this?

I am.
I wanted to be sure that other devs are aware of the other open PR where we might get merge conflicts after this change.

@atrol
atrol approved these changes Apr 1, 2020
@dregad dregad merged commit 65d47df into mantisbt:master-2.24 Apr 2, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.