Include cache key when including unversioned css #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When including our css files that don't have a version in the name, include cache key based on Mantis version. Fixes #26148
|
I pushed to PR branch to MantisBT repository by mistake, so will leave it there and cleanup after merge. |
|
A similar change is needed for inclusion of unversioned js files. I'm planning to do it once this PR is merged. |
dregad
requested changes
Aug 8, 2021
Fixes #26148
|
@dregad I pushed the refactored version. |
|
@dregad friendly reminder. Planning to merge this weekend. |
I have detached from #26148 the 2 changesets [1] that were created by the source integration plugin when you pushed to the issue26148_version_css branch in the mantisbt repo. [1]: For the record: |
CasN
pushed a commit
to CasN/mantisbt
that referenced
this pull request
Aug 29, 2022
When including our css files that don't have a version in the name, include cache key based on Mantis version. Refactored `html_css_link()` to have cache param. Fixes #26148, PR mantisbt#1773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When including our css files that don't have a version in the name,
include cache key based on Mantis version.
Fixes #26148