New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST API to fetch project users #1843
Merged
vboctor
merged 9 commits into
mantisbt:master
from
vboctor:issue22791_rest_api_project_handlers
Aug 25, 2022
Merged
REST API to fetch project users #1843
vboctor
merged 9 commits into
mantisbt:master
from
vboctor:issue22791_rest_api_project_handlers
Aug 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #22791
Fixes #22791
Fixes #22791
Fixes #22791
If no access level specified, get all users that can access the project. Fixes #22791
1. Query params should be modeled as query not option. 2. Remove pagination for SOAP API. 3. Use id instead of project_id for project_id. 4. Fix SOAP to return array of users. Fixes #22791
A user that doesn't have VIEWER access to a project, shouldn't be able to query its users. Fixes #22791
Fixes #22791
atrol
reviewed
Aug 21, 2022
atrol
reviewed
Aug 21, 2022
dregad
reviewed
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of duplicated code between rest_project_users() and rest_project_handlers() - maybe this can be avoided using a helper function ?
vboctor
force-pushed
the
issue22791_rest_api_project_handlers
branch
2 times, most recently
from
August 24, 2022 01:21
15647bc
to
f3f6aac
Compare
dregad
approved these changes
Aug 24, 2022
1. Remove redundant check. 2. Refactor functions that get project users to use helper function. 3. Fix warnings when user preference for language is set to auto. ixes #22791
vboctor
force-pushed
the
issue22791_rest_api_project_handlers
branch
from
August 25, 2022 03:30
f3f6aac
to
9a42597
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/api/rest/projects/:id/users
to get all users or all users with a specified access level or above. This functionality is available in SOAP API./api/rest/projects/:id/handlers
to get all users that can be assigned issues in the project.The user calling the API must have viewer access to the project. This was not enforced in SOAP API, but now it is.
Will submit a separate PR for Postman collection update, since there is a bunch of unrelated changes that accumulated over time.
Fixes #22791, #30907