Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests. Add test for helper_api::helper_get_link_attributes #1983

Merged
merged 5 commits into from Mar 31, 2024

Conversation

grummbeer
Copy link
Contributor

@grummbeer grummbeer commented Mar 30, 2024

This is the first commit of a series with the attempt to modernize the tests.

Issue: #34379

vendor/bin/phpunit tests/Mantis/Helper/GetLinkAttributesTest.php
PHPUnit 9.6.18 by Sebastian Bergmann and contributors.

.......                                                             7 / 7 (100%)

@grummbeer grummbeer changed the title Tests. Add test for helper::get_link_attrbutes Tests. Add test for helper_api::helper_get_link_attributes Mar 30, 2024
Copy link
Member

@dregad dregad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

I would suggest to document the test data sets' structure in PHPDoc, either with @param in testHelperReturnsArrayOrString block, or in provideConfigurations.

Commit message should reference the bugtracker issue it fixes (i.e. Fixes #xxx or Issue #xxx depending on whether you just want to automatically resolve the issue, or just reference it), so it gets automatically picked up by the source integration plugin.

Please read: https://mantisbt.org/wiki/doku.php/mantisbt:git_commit_messages

tests/Mantis/Helper/GetLinkAttributesTest.php Outdated Show resolved Hide resolved
tests/Mantis/Helper/GetLinkAttributesTest.php Outdated Show resolved Hide resolved
tests/Mantis/Helper/GetLinkAttributesTest.php Show resolved Hide resolved
@grummbeer
Copy link
Contributor Author

Fixed the array style. ready.

@dregad dregad merged commit aa93edb into mantisbt:master Mar 31, 2024
1 check passed
@grummbeer grummbeer deleted the test-get-link-attributes branch April 3, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants