Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Content-Security-Policy Headers #275

Merged
merged 1 commit into from Sep 8, 2014
Merged

Fix Content-Security-Policy Headers #275

merged 1 commit into from Sep 8, 2014

Conversation

grangeway
Copy link
Contributor

Firefox complains when accessing mantis 1.3 about the deprecated headers.

X-Content-Security-Policy is replaced by Content Security Policy

@dregad
Copy link
Member

dregad commented Aug 31, 2014

+1, but didn't someone mention wanting to drop CSP support ?

@grangeway
Copy link
Contributor Author

Given that it helps mitigate XSS, and that we accept a lot of user input to various pages/forms, and that the new version of the header is supported by safari, chrome and firefox. We published a blog post on our blog about how we would support this feature @ http://www.mantisbt.org/blog/?p=126

Not really sure why we would want to drop it...

@dregad
Copy link
Member

dregad commented Aug 31, 2014

I don't want to drop it myself actually. I just recalled reading something about it recently - here it is http://www.mantisbt.org/bugs/view.php?id=17491#c41140

@vboctor
Copy link
Member

vboctor commented Sep 1, 2014

I've added some comments to the discussion on the associated issue. I think since there is a standard version of the header, we should continue to adopt it. However, the question is whether to use the standard version in the browsers that support it, and fallback to non standard versions for ones that don't. See wikipedia article (status section) for the different versions of the header:

http://en.wikipedia.org/wiki/Content_Security_Policy

Our goal should to maximize the percentage of the pie where this functionality is effective. This will give us higher security and make it easier to find out when we break the functionality.

@dregad
Copy link
Member

dregad commented Sep 4, 2014

It's a good idea to have a fallback mechanism, assuming it does not generate too much overhead.

@atrol
Copy link
Member

atrol commented Sep 6, 2014

+1

Firefox complains when accessing mantis 1.3 about the deprecated headers.

X-Content-Security-Policy is replaced by Content Security Policy
@grangeway grangeway merged commit 91242cd into mantisbt:master Sep 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants