Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto set fixed in version #40

Closed

Conversation

vincentsels
Copy link
Contributor

Added a config option to automatically set the 'fixed in version' to the
'target version' upon resolving tickets.
We use this as a solution to http://www.mantisbt.org/bugs/view.php?id=11551

Added a config option to automatically set the 'fixed in version' to the
'target version' upon resolving tickets.
@vboctor
Copy link
Member

vboctor commented Feb 1, 2012

Thanks @vincentsels, nice feature. I wonder whether we need a config for this at all, since it is just defaulting rather than setting.

If we end up keeping the config option, then we need to update the manual to reflect this new configuration option.

@vincentsels
Copy link
Contributor Author

Something like that ? :)

@vboctor
Copy link
Member

vboctor commented Feb 1, 2012

Looks good, just include the default value in the documentation as well. Also make sure it is placed next to related configuration options, if there is such place.

Let's see what others think about the need for this configuration option, rather than having it as an always ON feature.

@rombert
Copy link
Member

rombert commented Feb 1, 2012

@vincentsels - nice addition. @vboctor - I don't feel strongly either way regarding the feature toggle. I slightly prefer not adding a setting, if at all possible, since it reduces the complexity of Mantis - both for developers and users.

@vboctor
Copy link
Member

vboctor commented Feb 1, 2012

Sounds good, let's not add the config option then.

@vincentsels
Copy link
Contributor Author

I'd update this, but I'm afraid i'd end up with something screwed up like #35 ;)
How do I do this correctly ?

@dregad
Copy link
Member

dregad commented Aug 1, 2012

@vincentsels I'm an expert on pull requests, but I think you should just keep adding commits to your fix branch (auto-set-fixed-in-version in this case); rebasing the branch will likely end up in a mess like #35 - I would think you should instead pull / merge master-1.2.x and resolve any conflicts as a new commit; otherwise it may be better/easier to just close this and open a new PR.

FavioGalvis pushed a commit to FavioGalvis/Inforequest that referenced this pull request Sep 14, 2015
pull updates from origin master
@dregad dregad closed this Apr 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants