Fix php errors with filters #525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the php errors that occur when clicking on View State, Match Type, and Highlight Changed. The change includes: - When a filter is retrieved for a user, if the user doesn't have a filter or something is wrong with it, return default fitler. - Move access to $g_filter into the filter_api and introduce filter_init() API. Default $g_filter in filter_api as well. - View State initialization should use correct type to avoid type mismatch in check_selected(). Fixes #17654
|
Is this a replacement / alternate fix for #319 ? |
|
Merged into master via cb23fb2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the php errors that occur when clicking on View State, Match Type, and Highlight Changed.
The change includes:
Fixes #17654