Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align issue title with id and remove link #536

Closed
wants to merge 1 commit into from
Closed

Align issue title with id and remove link #536

wants to merge 1 commit into from

Conversation

syncguru
Copy link
Contributor

@syncguru syncguru commented Nov 1, 2014

  • Remove link from issue title
  • Align issue title with the issue id

Fixes 17824

screen shot 2014-10-31 at 10 03 18 pm

@vboctor
Copy link
Member

vboctor commented Nov 1, 2014

+1

@dregad
Copy link
Member

dregad commented Nov 1, 2014

Please amend commit message to

  • add the 2 bullets in the PR description
  • include Fixes #17824 so that the changeset gets picked up automatically when merging.

I'm wondering if having the bug's summary as a link was not a good thing to have (it makes the click area to drill down into issues from "my view page" bigger). Maybe a more appropriate fix would be to change the CSS so that the link is not underlined. Thoughts ?

@syncguru
Copy link
Contributor Author

syncguru commented Nov 1, 2014

@dregad It crossed my mind. I decided against it though for couple of reasons:

1- It introduces one-off inconsistency with how links are done across the product
2- Potential clash with the cell background color (it much more pronounced than with the ID field)

I think this should be handled better in the modern UI.

@dregad
Copy link
Member

dregad commented Nov 1, 2014

OK I take your points. Let's leave it like that in 1.3.

+1

@atrol
Copy link
Member

atrol commented Nov 1, 2014

+1

As a side note: There has been a similar discussion for clickable summaries also for "View Issues" page
http://www.mantisbt.org/bugs/view.php?id=8066

@rombert
Copy link
Member

rombert commented Nov 1, 2014

+1

@syncguru
Copy link
Contributor Author

syncguru commented Nov 2, 2014

@dregad Amended the commit.

@vboctor
Copy link
Member

vboctor commented Nov 2, 2014

Merged into master via d793757

@vboctor vboctor closed this Nov 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants