ldap authentication: add an option not to cache passwords #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not everyone wants to cache passwords, even in hashed format. This new option caters to those users.
|
No time to have a deeper look at the moment.
|
|
That bug has been open for 5 years, damn :( I'm also fine with complete removing the caching, as it's a big security issue. |
| } else if( $t_login_method == LDAP && ldap_authenticate_by_username( $p_username, $p_password ) ) { | ||
| $t_auto_create = true; | ||
| $t_cache_password = config_get( 'ldap_cache_passwords' ); | ||
| $t_auto_create_password = $t_cache_password ? md5( $p_password ) : 'external-password'; |
There was a problem hiding this comment.
Let's use auto-generated password (instead of 'external-password') so that the password can't be guessed if auth method is changed for example. I would use a model like random cookie generation we already do.
|
@seveas let's remove this without configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not everyone wants to cache passwords, even in hashed format. This new
option caters to those users.