Do not wrap inline items for custom field value lists #781
Conversation
|
Any particular reason why you removed the for attribute on the labels ? Missing Fixes #20964 reference in commit message. +1 |
| @@ -321,10 +321,11 @@ function cfdef_input_checkbox( array $p_field_def, $p_custom_field_value ) { | |||
| for( $i = 0; $i < count( $t_values ); $i++ ) { | |||
| $t_input_id = 'custom_field_' . $p_field_def['id'] . '_value_' . $i; | |||
| $t_input_name = 'custom_field_' . $p_field_def['id'] . '[]'; | |||
| echo '<input id="$t_input_id" ' . helper_get_tab_index() . ' type="checkbox" name="' . $t_input_name . '" value="' . string_attribute( $t_values[$i] ) . '"'; | |||
| echo '<label class="nowrap">' ; | |||
Seems like having the input inside the label block, makes the label to apply the nowrap property to the whole content. (in the example of the checkbox list) (*) i've just noticed that in chrome there's a small chance that the checkbox is separated from the label, when no part of the label text fits in the current line. Firefox, however, works better in that situation, keeping the checkbox always attached to the label text... |
Avoid wrapping of each individual item that is part of a custom fields value list, displayed as inline inputs. Fixes #20964
cproensa
force-pushed
the
0020964_cf_nowrap
branch
from
a8416a0
to
5fe12d1
Compare
fixed |
|
Fixed in 1d3af0c |
Avoid wrapping of each individual item that is part of a custom
fields value list, displayed as inline inputs.
Fixes #0020964