Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of projects and subprojects menu bar #846

Closed
wants to merge 2 commits into from

Conversation

syncguru
Copy link
Contributor

Fixes #21137

screen shot 2016-08-13 at 11 00 15 pm

@@ -969,15 +974,13 @@ function layout_main_content_end() {
*/
function layout_page_content_begin() {
echo ' <div class="page-content">' , "\n";
echo ' <div class="row">' , "\n";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has no impact on other pages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the markup to the calling function (one level up) it should not have any side effect.

@vboctor
Copy link
Member

vboctor commented Aug 14, 2016

👍 with a couple of comments.

@dregad
Copy link
Member

dregad commented Aug 14, 2016

+1, didn't test if there is any regression per Victor's comment above.

@syncguru
Copy link
Contributor Author

@vboctor, @dregad comments addressed.

@dregad dregad added the merged label Aug 16, 2016
@dregad
Copy link
Member

dregad commented Aug 16, 2016

Merged in e1eb08b

@dregad dregad closed this Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants