Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable mypy pre-commit hook #137

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Enable mypy pre-commit hook #137

merged 3 commits into from
Aug 9, 2023

Conversation

alex-nork
Copy link
Contributor

@alex-nork alex-nork commented Aug 8, 2023 •
edited by zimventures

Closes out issue #136.

zimventures
zimventures approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@zimventures zimventures left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll create follow-on tickets to perform the cleanup work for various exclusions.

@alex-nork alex-nork merged commit 5d0d4fc into main Aug 9, 2023
5 checks passed
@zimventures zimventures deleted the AlexN/enable-mypy branch August 14, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimventures zimventures zimventures approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alex-nork @zimventures