configurable severity #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
August 16, 2023 15:03
…o create/edit/archive severities
zimventures
suggested changes
Aug 16, 2023
There was a problem hiding this comment.
Good stuff.
Ideally, it would be great to have the severity stuff broken out into its own application. Riding along side of the policy code things will start to get ugly (especially as Rules get more complicated). If it isn't too much trouble, breaking it out now would be a great step.
I apologize for not spelling that out in the original ticket 🙇♂️
|
Agreed that it feels a little clunky living in the Policy application. I'm happy to move it out 🚚 |
zimventures
reviewed
Aug 17, 2023
Comment on lines
49
to
+55
| 'account', | ||
| 'policy', | ||
| 'asset', | ||
| 'base_app', | ||
| 'embedding', | ||
| 'policy', | ||
| 'scan', | ||
| 'severity', |
There was a problem hiding this comment.
Doing The Lord's Work right here. 🙇♂️
zimventures
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this PR is to make rule severity configurable. With these changes, each severity will have a name, value, and color, instead of just a number. These severities are not user-specific, so all users can see severities that have been loaded/created, but only a superuser can create/edit/archive a severity.
There are two improvements that will be made in follow up PRs, in order to keep each a manageable size to review. The first improvement is to change the Rule severity field to a dropdown list populated by the existing severities. The second is tests.
Screenshots
Severity management dashboard
Create new severity
Severity created
Archive severity confirmation
Non-superuser dashboard view
Closes #155