Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Rule model #169

Merged
merged 2 commits into from Aug 22, 2023
Merged

Refactor Rule model #169

merged 2 commits into from Aug 22, 2023

Conversation

PedroAVJ
Copy link
Contributor

Redid pull request #167 as there was a big refactor that changed a lot of the tests and merge conflicts popped up.

Copy link
Contributor

@zimventures zimventures left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff all around - thanks for cooking up a new PR due to the merge conflicts.

@PedroAVJ
Copy link
Contributor Author

Forgot to add new migration files, since this affects the schema. Test should pass fine now.

@alex-nork alex-nork merged commit 69a721f into mantiumai:main Aug 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants