Refactor scan results and findings to support multiple types #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-nork
changed the title
zimventures
reviewed
Sep 6, 2023
Comment on lines
+85
to
+86
| {% include 'scan/_rule_table_rows.html' with unique_rules=unique_regex_rules %} | ||
| {% include 'scan/_rule_table_rows.html' with unique_rules=unique_multiquery_rules %} |
There was a problem hiding this comment.
viva reusable templates!!! 🍻
zimventures
reviewed
Sep 6, 2023
Comment on lines
+55
to
+61
| for result in results: | ||
| rule = result.rule | ||
|
|
||
| if rule.id not in rule_dict: | ||
| rule.finding_count = 0 | ||
| rule.findings = [] | ||
| rule_dict[rule.id] = rule |
There was a problem hiding this comment.
Just an educational note:
If/when we finally get a postgres backend, using distinct() would be the way to go here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to refactor the scan_run template and associated view to work with multiple finding/result/rule types.