Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

download terraform.py using local_exec #1582

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

langston-barrett
Copy link
Contributor

  • Installs cleanly on a fresh build of most recent master branch
  • Upgrades cleanly from the most recent release
  • Updates documentation relevant to the changes

fixes #1120

@sehqlr
Copy link
Contributor

sehqlr commented Jul 27, 2016

Is there anything else we need to do for this, or just testing?

@langston-barrett
Copy link
Contributor Author

langston-barrett commented Jul 28, 2016

@sehqlr You tell me! This has passed it's CI builds, so I'm not sure it even needs testing, just merging.

@sehqlr sehqlr self-assigned this Jul 29, 2016
@sehqlr
Copy link
Contributor

sehqlr commented Aug 9, 2016

@ryane: What do you think? Can we include this in 1.3?

@ryane
Copy link
Contributor

ryane commented Aug 9, 2016

I'm just wondering if we need a little documentation around upgrades. For example, it looks a user would have to run terraform apply or the equivalent curl command to download the inventory script.

And, when we bring this in, we'll definitely want to make sure the updated sample tf files are mentioned in the release notes (#1733)

Copy link
Contributor

@thomasvincent thomasvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

@Theaxiom Theaxiom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get the base branch stabilized before approaching this.

@Theaxiom Theaxiom removed this from the 1.3 milestone Apr 9, 2017
@thomasvincent thomasvincent dismissed Theaxiom’s stale review April 30, 2017 08:37

comment, not review

@thomasvincent
Copy link
Contributor

Resolved conflicts

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download terraform.py dynamically in Terraform
6 participants