This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
replace non alpha-num or - with - in service names #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to match Consul DNS limitations, any non-alpha-numeric chars other than '-' will be replaced with '-' in service names
ChrisAubuchon
added a commit
that referenced
this pull request
Jul 28, 2015
replace non alpha-num or - with - in service names
Closed
elg0nz
added a commit
to MustWin/kubernetes
that referenced
this pull request
Jul 21, 2016
Following the fix on [mesos-conul#19](mantl/mesos-consul#19) @ryane mentioned that the original separators were causing issues with other tools.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to match Consul DNS limitations, any non-alpha-numeric chars other than '-' will be replaced with '-' in service names